From a practical point of view
- if you end up swimming any distance avoid a cut that ends mid inner-thigh (square-cuts or shorts) as they'll probably chafe. Jammers or briefs are probably fine in this instance.
- briefs dry fast and take up less room in a bag, coupled with a microfibre towel and some goggles you can pack really light and still have an exercise kit.
- briefs with 1-2 inch side are perfectly acceptable for most places in my (british) experience - when you're in the water no-one's going to be able to see your package unless they're looking for it. Poolside, flaunt a little if you like.
- as with everything there's functional and fashion in swimwear. I prefer functional (hidden strings) "sensible" cut, designed for a workout. Some more fashion orientated brands (andrew christian, aussibum, addicted) are perfectly servicable but may be associated with a more flexible sexual attitude in certain regions. Select for your audience.
- Chlorine resistance is key for training suits, else your swimmers will degrade rapidly in months. Pick a pair marked for long life (eg Speedos Endurance+)
- don't be afraid to be a little louder with colour and pattern; I prefer folk to see me coming as, in a busy pool, a flash of colour is easier to spot.
- if you pick a pale/white pair, make sure it's got a lining in front, else, when wet, you'll transparently stand out enough to scare horses at 50 paces!
