If you're looking for dick pics, this is not the post for you, but the best urinal scene in the last 20 years is in "Stranger than fiction" from 2006 - if you are fast enough to notice it. Will Ferrell plays a character obsessed with numbers, which they portray by superimposing his thoughts over a lot of the action in the movie (eg he buys a muffin, and you watch him mentally processing the tip amount). The scene where he walks into the men's room is just dropped in there, but is basically what insecure men think whenever they enter a men's room. I couldn't find the scene (and I tried) - but a teaser for the movie to show how they display his thoughts ...
If anyone can find this well hidden (and excellent) scene. If I find it I will post.